From: Trond Myklebust Subject: Re: FMODE_EXEC or alike? Date: Wed, 22 Feb 2006 17:17:33 -0500 Message-ID: <1140646653.7879.25.camel@lade.trondhjem.org> References: <20060220221948.GC5733@linuxhacker.ru> <20060220215122.7aa8bbe5.akpm@osdl.org> <1140530396.7864.63.camel@lade.trondhjem.org> <20060221232607.GS22042@fieldses.org> <1140564751.8088.35.camel@lade.trondhjem.org> <20060222195721.GC28219@fieldses.org> <1140644216.7879.7.camel@lade.trondhjem.org> <20060222220435.GJ28219@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Oleg Drokin , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from pat.uio.no ([129.240.130.16]:29843 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S1751542AbWBVWRy (ORCPT ); Wed, 22 Feb 2006 17:17:54 -0500 To: "J. Bruce Fields" In-Reply-To: <20060222220435.GJ28219@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2006-02-22 at 17:04 -0500, J. Bruce Fields wrote: > What I don't understand is the source of the requirement that > FMODE_WRITE|FMODE_EXEC opens be disallowed. > > The only users of FMODE_EXEC introduced by Oleg's patch use a hardcoded > FMODE_READ|FMODE_EXEC, so it doesn't seem to impose any constraints on > the meaning of FMODE_WRITE|FMODE_EXEC. I understand FMODE_EXEC to mean that we want to call deny_write_access(). OTOH, FMODE_WRITE is supposed to trigger an automatic call to get_write_access(). Those two calls are mutually exclusive. Cheers, Trond