From: Daniel Stekloff Subject: [PATCH][XM-TEST] Remove Obsolete startNow() Method Date: Wed, 15 Mar 2006 20:46:43 -0800 Message-ID: <1142484403.4302.4.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-k2WEgnH/PsB8TfQwkVnh" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel , Ewan Mellor Cc: Dan Smith List-Id: xen-devel@lists.xenproject.org --=-k2WEgnH/PsB8TfQwkVnh Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, This patch removes the startNow() method from the XmTestDomain object. At one time, xm-test needed to wait for a domain to boot. There were two different methods: start, which did a wait, and startNow, which didn't wait. The wait was removed (except for HVM domains), so there's no difference between start and startNow(). Better to remove it. Thanks, Dan --=-k2WEgnH/PsB8TfQwkVnh Content-Disposition: attachment; filename=xmtest-remove-startNow.patch Content-Type: text/x-patch; name=xmtest-remove-startNow.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit # HG changeset patch # User stekloff@elm3b49.beaverton.ibm.com # Node ID f3f82890c4fc0a7c88ef76a26efb0e2f818df134 # Parent 1569bc48b0b8cbe7504c225752f7d36b8df2e537 Remove obsolete startNow() method from XmTestDomain object. Signed-off-by: Daniel Stekloff diff -r 1569bc48b0b8 -r f3f82890c4fc tools/xm-test/lib/XmTestLib/XenDomain.py --- a/tools/xm-test/lib/XmTestLib/XenDomain.py Wed Mar 15 20:25:50 2006 +0100 +++ b/tools/xm-test/lib/XmTestLib/XenDomain.py Wed Mar 15 16:35:35 2006 -0800 @@ -251,9 +251,6 @@ class XmTestDomain(XenDomain): if ENABLE_HVM_SUPPORT: waitForBoot() - def startNow(self): - XenDomain.start(self) - def minSafeMem(self): return 16 diff -r 1569bc48b0b8 -r f3f82890c4fc tools/xm-test/tests/create/10_create_fastdestroy.py --- a/tools/xm-test/tests/create/10_create_fastdestroy.py Wed Mar 15 20:25:50 2006 +0100 +++ b/tools/xm-test/tests/create/10_create_fastdestroy.py Wed Mar 15 16:35:35 2006 -0800 @@ -28,7 +28,7 @@ for i in range(0,50): for i in range(0,50): domain = XmTestDomain("testdomain") try: - domain.startNow() + domain.start() except DomainError,e: print "Failed: " + e.extra NSPerror = check_for_NSP_error(e.extra) diff -r 1569bc48b0b8 -r f3f82890c4fc tools/xm-test/tests/destroy/07_destroy_stale_pos.py --- a/tools/xm-test/tests/destroy/07_destroy_stale_pos.py Wed Mar 15 20:25:50 2006 +0100 +++ b/tools/xm-test/tests/destroy/07_destroy_stale_pos.py Wed Mar 15 16:35:35 2006 -0800 @@ -101,29 +101,24 @@ def test_sysrq(name): if not re.search("[Ee]rror", output): FAIL("sysrq failed to report error after destroy!") -def runTests(tests, wait): +def runTests(tests): for test in tests: domain = XmTestDomain() # Create a domain try: - if wait: - domain.start() - else: - domain.startNow() + domain.start() except DomainError, e: FAIL(str(e)) - - if wait: - # Attach a console and make sure it's live - try: - console = XmConsole(domain.getName()) - console.sendInput("foo") - console.runCmd("ls") - except ConsoleError, e: - FAIL(str(e)) + # Attach a console and make sure it's live + try: + console = XmConsole(domain.getName()) + console.sendInput("foo") + console.runCmd("ls") + except ConsoleError, e: + FAIL(str(e)) # Destroy it @@ -137,9 +132,5 @@ tests = [test_mem_set, test_pause, test_ test_block_list, test_shutdown, test_domid, test_domname] if verbose: - print "Running stale tests (nice mode)" -runTests(tests, True) - -if verbose: - print "Running stale tests (mean mode)" -runTests(tests, False) + print "Running stale tests" +runTests(tests) --=-k2WEgnH/PsB8TfQwkVnh Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=-k2WEgnH/PsB8TfQwkVnh--