From: Mark McLoughlin Subject: Re: [PATCH] netfront: support ethtool's get_link() Date: Mon, 17 Jul 2006 10:30:26 +0100 Message-ID: <1153128626.2623.13.camel@localhost.localdomain> References: <1152890168.12312.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-UyQMbXj/BmbKtc+zT29T" Return-path: In-Reply-To: <1152890168.12312.5.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=-UyQMbXj/BmbKtc+zT29T Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, I hadn't spotted that netfront already supports some ethtool ops. That was just dumb; apologies. More correct patch attached. Thanks, Mark. On Fri, 2006-07-14 at 16:16 +0100, Mark McLoughlin wrote: > Hi, > Attached is a very simple patch to support ethtool's get_link() > operation. This allows things like NetworkManager's and anaconda's > carrier detection code to work with netfront. > > It seems sane to take the simple approach of reporting the link as > active as soon as we've connected to the backend device. It's irrelevant > whether the physical device in dom0 has link, since there could well be > someone else on the bridge responding. --=-UyQMbXj/BmbKtc+zT29T Content-Disposition: attachment; filename=xennet-ethtool-get-link.patch Content-Type: text/x-patch; name=xennet-ethtool-get-link.patch; charset=utf-8 Content-Transfer-Encoding: 7bit --- ./drivers/xen/netfront/netfront.c.ethtool 2006-07-14 16:49:22.000000000 +0100 +++ ./drivers/xen/netfront/netfront.c 2006-07-17 11:26:49.000000000 +0100 @@ -1215,6 +1215,7 @@ .set_tx_csum = ethtool_op_set_tx_csum, .get_sg = ethtool_op_get_sg, .set_sg = xennet_set_sg, + .get_link = ethtool_op_get_link, }; #ifdef CONFIG_SYSFS --=-UyQMbXj/BmbKtc+zT29T Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=-UyQMbXj/BmbKtc+zT29T--