From: "Randy Dunlap" Subject: Re: [RFC PATCH 09/33] Add start-of-day setup hooks to subarch Date: Tue, 18 Jul 2006 06:07:18 -0700 Message-ID: <1153228038.10819@shark.he.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Arjan van de Ven , Chris Wright , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Jeremy Fitzhardinge , Andi Kleen , Andrew Morton , Rusty Russell , Zachary Amsden , Ian Pratt , Christian Limpach , Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org > On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote: > > plain text document attachment (i386-setup) > > Implement the start-of-day subarchitecture setup hooks for booting on > > Xen. Add subarch macros for determining loader type and initrd > > location. > > > diff -r a5848bce3730 arch/i386/kernel/setup.c > > --- a/arch/i386/kernel/setup.c Thu Jun 22 16:02:54 2006 -0400 > > +++ b/arch/i386/kernel/setup.c Thu Jun 22 20:20:31 2006 -0400 > > @@ -458,6 +458,7 @@ static void __init print_memory_map(char > > } > > } > > > > +#ifndef HAVE_ARCH_E820_SANITIZE > > /* > > * Sanitize the BIOS e820 map. > > * > > @@ -677,6 +678,7 @@ int __init copy_e820_map(struct e820entr > > } while (biosmap++,--nr_map); > > return 0; > > } > > +#endif > > > Hi, > > what is this for? Isn't this 1) undocumented and 2) unclear and 3) > ugly ? (I'm pretty sure the HAVE_ARCH_* stuff is highly deprecated for > new things nowadays) I've read that Linus doesn't like it (putting it mildly), but deprecated?? Yes, there are better/other ways. --- ~Randy