From: Jeremy Katz Subject: Re: [PATCH] Paravirt framebuffer use xvc as console [4/5] Date: Tue, 05 Sep 2006 12:11:59 -0400 Message-ID: <1157472719.7571.90.camel@aglarond.local> References: <1157227130.11059.44.camel@aglarond.local> <20060904090111.GB4812@cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060904090111.GB4812@cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Steven Smith Cc: xen-devel , Markus Armbruster , sos22@srcf.ucam.org, Amos Waterland List-Id: xen-devel@lists.xenproject.org On Mon, 2006-09-04 at 10:01 +0100, Steven Smith wrote: > > This is the patch from Amos Waterland for the xenconsole to > > use /dev/xvc0 instead of taking over ttys. I've fixed a few places > > which needed to check for XVC mode in addition to serial mode. Also, > > until LANANA responds with an official minor, I've adjusted it to use > > char 250/187 (in the experimental range) as opposed to 204/187. > > > > (Should be identical to this patch from last time) > Does this have anything to do with the virtual framebuffer work, or > does it stand alone? It stands alone, but without it, the framebuffer bits get a little confusing to actually try to have used as the console. > > @@ -194,11 +209,17 @@ static int __init xen_console_init(void) > > kcons_info.write = kcons_write_dom0; > > } else { > > if (xc_mode == XC_DEFAULT) > > - xc_mode = XC_TTY; > > + xc_mode = XC_XVC; > Not convinced we want to change the default until a little while after > the rest of the patch gets merged. The default *HAS* to be changed -- otherwise, the xvc console tries to take over ttys (which is really really really wrong in the guest) Jeremy