From: Hollis Blanchard Subject: [PATCH][XEND] Fix yet another information-destroying backtrace in Xend Date: Tue, 05 Sep 2006 16:18:31 -0500 Message-ID: <1157491111.20425.68.camel@basalt.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ewan Mellor , Alistair Tse Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Every time you call traceback.print_exc() from an exception handler, you throw away all the traceback information you've accumulated to get to that spot. I'm not going to do a global find/replace without testing, but I know the below patch works and is needed. Fix yet another information-destroying backtrace in Xend. Signed-off-by: Hollis Blanchard diff -r 343c37f11a8b tools/python/xen/xend/server/SrvDaemon.py --- a/tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 14:44:20 2006 -0500 +++ b/tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 16:12:25 2006 -0500 @@ -293,7 +293,7 @@ class Daemon: except Exception, ex: print >>sys.stderr, 'Exception starting xend:', ex if XEND_DEBUG: - traceback.print_exc() + raise log.exception("Exception starting xend (%s)" % ex) if status: status.write('1') -- Hollis Blanchard IBM Linux Technology Center