From: Ian Campbell Subject: Re: [PATCH][RESEND] PV drivers for HVM guests Date: Wed, 25 Oct 2006 12:03:32 +0100 Message-ID: <1161774212.22514.86.camel@localhost.localdomain> References: <4535F8F5.E57C.0030.0@novell.com> Your message of Wed, 18 Oct 2006 07:51:45 -0600. <4535F8F5.E57C.0030.0@novell.com> <200610182356.k9INuAF03840@photon.sky.yk.fujitsu.co.jp> <45374AE9.E57C.0030.0@novell.com> Your message of Thu, 19 Oct 2006 07:53:42 -0600. <45374AE9.E57C.0030.0@novell.com> <200610201012.k9KACIF29714@photon.sky.yk.fujitsu.co.jp> <45389CA5.E57C.0030.0@novell.com> <200610230145.k9N1jGF01307@photon.sky.yk.fujitsu.co.jp> <453D8055.4030509@jp.fujitsu.com> <1161703595.22514.59.camel@localhost.localdomain> <200610242354.k9ONsIF02543@photon.sky.yk.fujitsu.co.jp> <200610250311.k9P3BwF04686@photon.sky.yk.fujitsu.co.jp> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200610250311.k9P3BwF04686@photon.sky.yk.fujitsu.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Doi.Tsunehisa@jp.fujitsu.com Cc: Ky Srinivasan , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, 2006-10-25 at 12:11 +0900, Doi.Tsunehisa@jp.fujitsu.com wrote: > I've met a compile error about gfp_t in rhel4.4. Thus, I avoided to meet > the compile error with preliminary patch like below. Oh, you mean you were seeing problems because gfp_t is backported to RHEL 4.4? I thought your patch was adding the typedef but actually you are conditionally removing it. I not sure the typedef is needed at all -- nothing in unmodified_drivers uses gpf_t as far as I can see. My current patchset doesn't define it at all and builds ok on RHEL4.4. Perhaps it is an arch specific issue? Cheers, Ian.