From: Jeff Layton Subject: Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability Date: Tue, 07 Nov 2006 16:13:00 -0500 Message-ID: <1162933980.28425.64.camel@dantu.rdu.redhat.com> References: <1162838843.12129.8.camel@dantu.rdu.redhat.com> <20061106202313.GA691@wohnheim.fh-wedel.de> <454FA032.1070008@redhat.com> <20061106211134.GB691@wohnheim.fh-wedel.de> <454FAAF8.8080707@redhat.com> <1162914966.28425.24.camel@dantu.rdu.redhat.com> <20061107172835.GB15629@wohnheim.fh-wedel.de> <20061107174217.GA29746@wohnheim.fh-wedel.de> <20061107175601.GB29746@wohnheim.fh-wedel.de> <1162928464.28425.59.camel@dantu.rdu.redhat.com> <20061107204135.GF29746@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Sandeen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:33217 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1753034AbWKGVPa (ORCPT ); Tue, 7 Nov 2006 16:15:30 -0500 To: =?ISO-8859-1?Q?J=F6rn?= Engel In-Reply-To: <20061107204135.GF29746@wohnheim.fh-wedel.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2006-11-07 at 21:41 +0100, J=C3=B6rn Engel wrote: > On Tue, 7 November 2006 14:41:04 -0500, Jeff Layton wrote: > >=20 > > How about this patch instead here? I don't think anything depends= on > > i_ino being any certain value for these files, and this seems less > > "magic-numbery". This should also mostly prevent us from assigning = out > > i_ino=3D0. >=20 > nfsctl_transaction_write() appears to depend on i_ino. >=20 > J=C3=B6rn >=20 Ahh, correct. That could probably stand to be a bit more robust, but I don't want to tackle it now. How about this instead, which should just set it to the maximum allowed value of s->s_lastino? It might throw a compile-time warning about overflowing i_ino, but I think it'll still work. Signed-off-by: Jeff Layton diff --git a/fs/libfs.c b/fs/libfs.c index bd08e0e..d9f4e3e 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -373,6 +373,9 @@ int simple_fill_super(struct super_block inode =3D new_inode(s); if (!inode) return -ENOMEM; + /* ino must not collide with any ino assigned in the loop below. Set + it to the highest possible inode number */ + inode->i_ino =3D (1 << (sizeof(s->s_lastino) * 8)) - 1; inode->i_mode =3D S_IFDIR | 0755; inode->i_uid =3D inode->i_gid =3D 0; inode->i_blocks =3D 0; - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html