From: Ian Campbell Subject: Re: [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unstable-12502) Date: Tue, 28 Nov 2006 18:24:04 +0000 Message-ID: <1164738244.3336.214.camel@localhost.localdomain> References: <20061122071050.24010.92547.sendpatchset@localhost> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061122071050.24010.92547.sendpatchset@localhost> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Magnus Damm Cc: Ian Pratt , Kazuo Moriwaka , xen-devel@lists.xensource.com, magnus.damm@gmail.com, Akio Takebe , Isaku Yamahata , Horms List-Id: xen-devel@lists.xenproject.org Hi Magnus, On Wed, 2006-11-22 at 16:10 +0900, Magnus Damm wrote: > [PATCH 00/04] Kexec / Kdump: Release 20061122 (xen-unstable-12502) I've been playing a bit more and found a problem. You define a per CPU variable crash_notes and on crash you loop over NR_CPUS and clear the notes for CPUS which don't exist. Unfortunately the percpu regions for CPUs which aren't physically present is returned to the heap on boot (see percpu_free_unused_areas) -- this means that you zero out heap pages on crash :-( You need to use num_{possible,present,online}_cpus() in machine_crash_kexec() and kexec_get_cpu() instead of NR_CPUS. Cheers, Ian.