From: Ian Campbell Subject: Re: Re: [patch] Add kexec_ops & function pointers Date: Tue, 12 Dec 2006 11:27:02 +0000 Message-ID: <1165922822.23643.34.camel@localhost.localdomain> References: <20061208161729.913385000@suse.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Magnus Damm Cc: Gerd Hoffmann , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, 2006-12-12 at 16:12 +0900, Magnus Damm wrote: > Basically, machine_kexec() should be converted to kexec_ops.kexec() in > two places. The second place is unfortunately located in > linux/kernel/sys.c which does not exist in sparse yet. So that needs > to be resolved somehow. Hiding the indirections through the function table in the header via defines or inline functions would make things a lot cleaner in my opinion and as a bonus avoid this addition to the sparse tree. That is the approach taken by the paravirt_ops stuff so it would also make it easier to integrate with that in the future. Ian.