From: Steven Whitehouse Date: Fri, 15 Dec 2006 15:16:17 +0000 Subject: [Cluster-devel] [PATCH] Fix change nlink deadlock In-Reply-To: <4582B644.4020103@redhat.com> References: <4582B644.4020103@redhat.com> Message-ID: <1166195777.3752.1192.camel@quoit.chygwyn.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Fri, 2006-12-15 at 09:50 -0500, Wendy Cheng wrote: > Bugzilla 215088 > > Fix deadlock in gfs2_change_nlink() while installing RHEL5 into GFS2 > partition. The gfs2_rename() apparently needs block allocation for the > new name (into the directory) where it requires rg locks. At the same > time, while updating the nlink count for the replaced file, > gfs2_change_nlink() tries to return the inode meta-data back to resource > group where it needs rg locks too. Our logic doesn't allow process to > acquire these locks recursively by the same process (RHEL installer) > that results a BUG call. This only happens within rename code path and > only if the destination file exists before the rename operation. > > Patch passed a simulated test program created for this issue yesterday - > havn't really tried it out on installer yet. Will continue to installer > test today. Pass it up for a quick eyeball examine. > > -- Wendy That looks good to me, so let me know if it passes the tests and I'll push the patch into the -nmw tree in that case, Steve.