From: Jacob Gorm Hansen Subject: [PATCH] mini-os: Properly release xenbus ids Date: Thu, 05 Apr 2007 23:07:50 +0200 Message-ID: <1175807270.22056.2.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-obq5laiAJwwdPrwRb9Ci" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel List-Id: xen-devel@lists.xenproject.org --=-obq5laiAJwwdPrwRb9Ci Content-Type: text/plain Content-Transfer-Encoding: 7bit If more than NR_REQS xenbus requests have been made, xenbus locks up in an infinite loop. This simple patch fixes this, and also removes waiters from the xenbus wait queues. Regards, Jacob --=-obq5laiAJwwdPrwRb9Ci Content-Disposition: attachment; filename=xenbus_release_id.patch Content-Type: text/x-patch; name=xenbus_release_id.patch; charset=us-ascii Content-Transfer-Encoding: 7bit diff -r 282bb4b03e5c extras/mini-os/xenbus/xenbus.c --- a/extras/mini-os/xenbus/xenbus.c Thu Apr 05 21:34:09 2007 +0200 +++ b/extras/mini-os/xenbus/xenbus.c Thu Apr 05 23:05:34 2007 +0200 @@ -195,6 +195,7 @@ static void release_xenbus_id(int id) { BUG_ON(!req_info[id].in_use); spin_lock(&req_lock); + req_info[id].in_use = 0; nr_live_reqs--; if (nr_live_reqs == NR_REQS - 1) wake_up(&req_wq); @@ -350,6 +351,7 @@ xenbus_msg_reply(int type, xb_write(type, id, trans, io, nr_reqs); schedule(); + remove_waiter(w); wake(current); rep = req_info[id].reply; --=-obq5laiAJwwdPrwRb9Ci Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=-obq5laiAJwwdPrwRb9Ci--