From: "davidben (Code Review)" Date: Wed, 15 Apr 2026 17:27:38 +0000 In-Reply-To: References: Reply-To: davidben@...410..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606... Message-ID: <11768229532ab3281f39684165b0a9c2a19b02b0-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="hm4BLFxf0bY="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Fix some CRL mixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: MaxF , plaisthos , openvpn-devel --hm4BLFxf0bY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, flichtenheld. davidben has posted comments on this change by davidben. ( http://gerrit.op= envpn.net/c/openvpn/+/1289?usp=3Demail ) Change subject: ssl_openssl: Fix some CRL mixups ...................................................................... Patch Set 12: (1 comment) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1289/comment/4e11b60a_6a1828e8?usp=3D= email : PS12, Line 321: X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->cr= ls); > Does this function copy the CRLs into ctx, or a pointer to them? Pointer to them. set0 functions in OpenSSL generally are a pointer to them. > If it's the latter, does this modified X509_STORE_CTX continue to exist i= nside the SSL_CTX after this callback? Nope. OpenSSL is very inconsistent about the relationship between `FOO` and= `FOO_CTX`. `X509_STORE` is shared configuration between certificate verifi= cations, while `X509_STORE_CTX` is a single certificate verification operat= ion. So this object will be freed shortly after this function returns. It's= just a vehicle for passing the verification bits to the caller. > (What I'm getting at is, do we need to worry about dangling pointers if r= eload_crl is called?) Should be OK! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe Gerrit-Change-Number: 1289 Gerrit-PatchSet: 12 Gerrit-Owner: davidben Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: MaxF Gerrit-Comment-Date: Wed, 15 Apr 2026 17:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF --hm4BLFxf0bY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, flichtenheld.

View = Change

1 comment:

    =
  • File src/openvpn/ssl_openssl.c:

    =
    • Patch Set= #12, Line 321: X50= 9_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->crls);

      Does this function copy the CRLs into ctx, or a= pointer to them?

      Pointer to them. set0 functions in OpenS= SL generally are a pointer to them.

      If it&#= 39;s the latter, does this modified X509_STORE_CTX continue to exist inside= the SSL_CTX after this callback?

      Nope. OpenSSL is very in= consistent about the relationship between `FOO` and `FOO_CTX`. `X509_STORE`= is shared configuration between certificate verifications, while `X509_STO= RE_CTX` is a single certificate verification operation. So this object will= be freed shortly after this function returns. It's just a vehicle for = passing the verification bits to the caller.

      <= p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">= (What I'm getting at is, do we need to worry about dangling pointers if= reload_crl is called?)

      Should be OK!

  • To view, visit change 1289. To unsubscribe, or for help writing mail filt= ers, visit setti= ngs.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I31ac2a763209114267c35c4a918= 2a12d8d82f6fe
    Gerrit-Change-Number: 1289
    Gerrit-PatchSet: 12
    Gerrit-Owner: davidben <davidben@...410...&= gt;
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: MaxF <max@...2606...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: MaxF <max@...2606...> =
    Gerrit-Comment-Date: Wed, 15 Apr 2026 17:27:38= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: MaxF <max@...2606...&g= t;
    = --hm4BLFxf0bY=--