From: Ian Campbell <Ian.Campbell@XenSource.com>
Subject: Re: Re: [PATCH] kexec: framework and i386 (Take XIV)
Date: Tue, 29 May 2007 10:04:21 +0100
Message-ID: <1180429461.13758.15.camel@localhost.localdomain>
References: <20060901025610.GE31034@verge.net.au>
	<A5C6CDA26D3151takebe_akio@jp.fujitsu.com>
	<A6C6CDA30C4336takebe_akio@jp.fujitsu.com>
	<20060901102116.GN17801@verge.net.au>
	<BDC6D06B746C01takebe_akio@jp.fujitsu.com>
	<20070528052833.GA4374@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
In-Reply-To: <20070528052833.GA4374@verge.net.au>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Horms <horms@verge.net.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, Kazuo Moriwaka <moriwaka@valinux.co.jp>, xen-devel@lists.xensource.com, "Zou, Nanhai" <nanhai.zou@intel.com>, Akio Takebe <takebe_akio@jp.fujitsu.com>, Isaku Yamahata <yamahata@valinux.co.jp>, Magnus Damm <magnus@valinux.co.jp>, Mark Williamson <mark.williamson@cl.cam.ac.uk>, xen-ia64-devel@lists.xensource.com

On Mon, 2007-05-28 at 14:28 +0900, Horms wrote:
> [ Ian Campbell added to CC list ]
> 
> On Tue, Sep 05, 2006 at 06:45:35AM +0900, Akio Takebe wrote:
> > Hi, Horms
> > 
> > I tested the following patch with Horms kexec patch.
> > 
> > My tests is:
> >   push NMI bottun after loading kdump kernel.
> >   
> > The results is:
> >   OK, I could get vmcore
> 
> 
> Hi Takebe-san,
> 
> this patch seems ok to me, but it seems that it never went into the
> tree. Ian, what are your thoughts on it?

The default in non-debug builds is to forward the crash to domain 0 so
we'd never get here, although I'd expect domain 0 probably does a kdump
itself nowadays when an NMI is received.

For debug builds I guess it does make sense. Assuming crash_kexec
gracefully returns if no crash kernel has been loaded, so that the old
behaviour is preserved, then the behaviour would be fine with me.
Alternatively "nmi=kdump" on the command line might be nice.

> > +extern void crash_kexec(struct cpu_user_regs *regs);

I can't find kexec_crash in xen-unstable. Is it now crash_kexec, with no
parameters? Whatever the function is now called it should probably be in
a header somewhere therefore no local prototype required.

> > +        else if ( !nmi_watchdog ){

Needs a space between ) and {.

Ian.