From: Jesper Dangaard Brouer Subject: Re: [FIX] Re: Make/compile error for iptables-1.4.0rc1 Date: Fri, 23 Nov 2007 15:30:01 +0100 Message-ID: <1195828201.3866.20.camel@localhost.localdomain> References: <1195245146.15945.50.camel@localhost.localdomain> <1195390182.15945.57.camel@localhost.localdomain> <1195395787.15945.77.camel@localhost.localdomain> <1195600242.1228.7.camel@localhost.localdomain> <4743E403.8090408@trash.net> <1195673456.1228.14.camel@localhost.localdomain> <47455A68.3030309@trash.net> Reply-To: jdb@comx.dk Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: yasuyuki@netfilter.org, Netfilter Developers To: Patrick McHardy Return-path: Received: from lanfw001a.cxnet.dk ([87.72.215.196]:53789 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755125AbXKWObp (ORCPT ); Fri, 23 Nov 2007 09:31:45 -0500 In-Reply-To: <47455A68.3030309@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, 2007-11-22 at 11:31 +0100, Patrick McHardy wrote: > Jesper Dangaard Brouer wrote: > > On Wed, 2007-11-21 at 08:53 +0100, Patrick McHardy wrote: > >> Jesper Dangaard Brouer wrote: > >>> The problem is that "linux/netfilter/x_tables.h" got included in SVN > >>> (changeset 6920). The fix is to delete it from SVN, so that the systems > >>> "x_tables.h" has effect again. > >>> > >>> Can someone with SVN write access fix this? > >>> > >>> "svn rm include/linux/netfilter/x_tables.h" > >> > >> Actually the fix is the other way around, we want to be able to > >> build iptables without having kernel sources locally. So I > >> guess the x_tables.h file should be resynced or something? > > > > If thats what you want, we need to add ip_tables.h in > > include/linux/netfilter_ipv4/. Its the interaction between ip_tables.h > > and x_tables.h that screw things up. > > Since you seem to be able to test it, would you care to send a patch? :) You can see/test it your self by logging in on people.netfilter.org and compile iptables-1.4.0rc1. Okay, I'll post a patch. It should be a quite simple task, of adding include/linux/netfilter_ipv4/ip_tables.h and include/linux/netfilter/x_tables.h from kernel source. BUT before posting the patch I'll first test it, on debian and Gentoo again. > > Both ip_tables.h and x_tables.h are part of the kernel source code. > > Thare might be some dependencies to specific kernel, so it might not be > > wise to include the files in SVN as we make a dependency to this > > specific kernel, and we also needs to keep them in sync. > > The interface between userspace and kernel is stable, there's no > risk by including those files. If you say so, we'll add the files to SVN / the iptables package. -- Med venlig hilsen / Best regards Jesper Brouer ComX Networks A/S Linux Network developer Cand. Scient Datalog / MSc. Author of http://adsl-optimizer.dk LinkedIn: http://www.linkedin.com/in/brouer