From: Stelian Pop Date: Sun, 13 Apr 2008 15:35:05 +0200 Subject: [U-Boot-Users] [PATCH] Add support for AT91RM9200EK board In-Reply-To: <1208030816.23686.13.camel@elrond.atmel.sweden> References: <1208030816.23686.13.camel@elrond.atmel.sweden> Message-ID: <1208093705.23686.8.camel@voyager.dsnet> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le samedi 12 avril 2008 ? 22:06 +0200, Ulf Samuelsson a ?crit : > Add support for the AT91RM9200EK Board. Hi Ulf, I do have a few issues with your patch. As you have seen, I started adapting the Atmel changes for the AT91SAM boards, and in doing so I tried to implement (well, quite a lot was borrowed from Linux) a common infrastructure for the SAM9 and CAP9 CPUs/boards. I think that the AT91RM9200 could integrate quite well in the existing framework. I haven't done the job myself yet because I have quite limited ressources at the moment (and this is why I chose 'arch-at91sam9' instead of 'arch-at91'...) but since you're contributing a new port it may be the right time to do it. This means for example: - using at91 gpio macros: at91_set_A_periph(), etc. - using the standard CFI flash driver instead of the custom one - maybe others... Ah, and it would be much easier to quote and comment on your patches if they were inlined in your mails. Thanks, Stelian. -- Stelian Pop