Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jmr7S-00072d-Ff for mharc-grub-devel@gnu.org; Fri, 18 Apr 2008 09:59:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jmr7R-00072T-HN for grub-devel@gnu.org; Fri, 18 Apr 2008 09:59:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jmr7O-0006zE-Gv for grub-devel@gnu.org; Fri, 18 Apr 2008 09:59:12 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jmr7O-0006z4-DT for grub-devel@gnu.org; Fri, 18 Apr 2008 09:59:10 -0400 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jmr7O-00071E-9I for grub-devel@gnu.org; Fri, 18 Apr 2008 09:59:10 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3IDwxFt026486 for ; Fri, 18 Apr 2008 09:58:59 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3IDwwON010759 for ; Fri, 18 Apr 2008 09:58:59 -0400 Received: from [10.32.4.66] (vpn-4-66.str.redhat.com [10.32.4.66]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m3IDwu8t031803 for ; Fri, 18 Apr 2008 09:58:58 -0400 From: Lubomir Kundrak To: The development of GRUB 2 In-Reply-To: <20080418113259.GD26239@thorin> References: <1208212240.3971.48.camel@localhost.localdomain> <20080415133805.GG21548@thorin> <1208433201.770.43.camel@localhost.localdomain> <20080417201107.GB13794@thorin> <20080417222114.reel0vq6f40gsskc@webmail.spamcop.net> <20080418113259.GD26239@thorin> Content-Type: text/plain Organization: Red Hat Inc. Date: Fri, 18 Apr 2008 15:58:55 +0200 Message-Id: <1208527135.16288.2.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Make gdb debugging a bit less painful X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Apr 2008 13:59:13 -0000 On Fri, 2008-04-18 at 13:32 +0200, Robert Millan wrote: > On Thu, Apr 17, 2008 at 10:21:14PM -0400, Pavel Roskin wrote: > > Quoting Robert Millan : > > > > >Now that I think of it, is there any reason for doing all the cmain() > > >cruft before grub_main() ? Getting to grub_main() only requires a working > > >stack, which we have, and grub_main() inmediately returns control back to > > >architecture-specific code in grub_machine_init(). > > > > > >So why not move from: > > > > > > _start -> cmain -> grub_main > > > > > >to: > > > > > > _start -> grub_main -> grub_machine_init -> cmain > > > > > >? > > > > I think it would be great. We should try to make the code for > > different architectures more uniform to simplify maintenance. > > Here. Unfortunately I can't test it as I have no ieee1275 at hand currently. > > Anyone? I have an OLPC XO machine borrowed now. I will test that this evening. -- Lubomir Kundrak (Red Hat Security Response Team)