From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <ca0f59980806272158g1221d360o3c447bf459c4f8e4@mail.gmail.com>
References: <1214601899.9513.58.camel@dv>
	<ca0f59980806272158g1221d360o3c447bf459c4f8e4@mail.gmail.com>
Content-Type: text/plain
Date: Mon, 30 Jun 2008 18:43:59 -0400
Message-Id: <1214865839.2423.11.camel@dv>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [RFC PATCH] Sector 2 of non-embedded core.img: write early or
	patch later?
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>

On Sat, 2008-06-28 at 12:58 +0800, Bean wrote:
> On Sat, Jun 28, 2008 at 5:24 AM, Pavel Roskin <proski@gnu.org> wrote:
> > I tend to prefer the later ("write early") approach, but I'd like to see
> > some feedback before I commit it.
> 
> Hi,
> 
> The problem of write early is that it changes the target image before
> verification is made, so if verification fails, the change remains.
> This is generally not a good practice, we should not touch core.img if
> it can't be embedded successfully.

OK, that's a good argument.  Actually, if grub-install is used, core.img
would have been rewritten already.  Anyway, core.img is a file we want
to touch as little as possible, considering that it can already be used.

I'm applying the "patch-later" patch with some simplifications and
warning fixes.

-- 
Regards,
Pavel Roskin