Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59E8CC433F5 for ; Fri, 18 Mar 2022 12:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rMt39A0wsn6B2TDFZ39rrMVr01hhPQ7/kU66UKioCHE=; b=JdFOrs/kjSoXlt hOygs51MiRhIBvmleXk6AjDSPL1CiolKXtE3ujn2ylWFK7+Y9G1u3siDQ9ZutgalGnSXvwmKMpl7I J5jvOS27KeKJeX6ZB0q275AJ/3EDm+HQwT5OynpUybtQ+HcBQ57ajEW+jtQ/979HDdfvArlT5rJZP AslxPFnTaODhrVxImIlOGY90qv6xqZG4OLOfGDKIOuMwVEPdgzqdYHvPbRbnlRX69H9Ohgcy3s1aU H03SMK6VjfOFe+5BRiI4PNzYCJqRLccKM1V8ITouFoIiRGh4i1FDt+/g/JWFuRudHwFY9oZUNhmZL rnMHWrVCAhjvrxxoPxhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVBHO-001Vfp-5x; Fri, 18 Mar 2022 12:00:26 +0000 Received: from mail-lj1-f179.google.com ([209.85.208.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVBHL-001Vf0-9J for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 12:00:24 +0000 Received: by mail-lj1-f179.google.com with SMTP id h11so11026712ljb.2 for ; Fri, 18 Mar 2022 05:00:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UMlymXAg/La3f+jWCU8kQv3G8Z6GY6dmL1ojY/fXBXs=; b=xPYlARi0Fer792SgEC+sdoV2BCu6N0eIJChfqzVxy58XbetS/RKAEIXpqGnGeL64Lh JSS+bc5JJMQGbO7cbjEexiLnOwrZhagA2ghhF18kdWJuom53HaXgAH79qlJSI4+6tvyJ eVTew9JlsNp1c7ANryDNA43cstwC/xAEoZibDYwz4yRZJgisYTTpV8DhpreMAJOANVCf eXzOKEV6JDesqn2/xABaxWb7iRsxuX1Yrgj3if+VDWoZY1buwxksKfjNDcDGdYMQIQAK s+y/mGKGDKRbI+aJb/V09RSVX3JOoMzI7TYEHX0yOL9cMrg+xLtFqnEh1KPL1k3EAd0+ qzPw== X-Gm-Message-State: AOAM530u7GgnkaGWRROHgjiMztD2JKf5SqEPO/CZXKXltwy/G6rplp+p b3IjvAQCzIc+tKgweMnTuGSlyQAx0sM= X-Google-Smtp-Source: ABdhPJzaJYpcaxCif/7uzFS52fg32S0i/CSgiZjzimuKfuuvn43sJYmjdtzgmw+IyxX8gR8dyuk3Sg== X-Received: by 2002:a2e:9886:0:b0:248:2bf:2d14 with SMTP id b6-20020a2e9886000000b0024802bf2d14mr5720668ljj.159.1647604821032; Fri, 18 Mar 2022 05:00:21 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id u12-20020a056512128c00b00446499f855dsm820330lfs.78.2022.03.18.05.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 05:00:20 -0700 (PDT) Message-ID: <1217ab63-f441-a757-2864-e1b01ab54349@kernel.org> Date: Fri, 18 Mar 2022 13:00:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] arm64: dts: n5x: add sdr edac support Content-Language: en-US To: Dinh Nguyen , robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-arm-kernel@lists.infradead.org References: <20220301151238.15836-1-dinguyen@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220301151238.15836-1-dinguyen@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_050023_368757_F426702C X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2022 16:12, Dinh Nguyen wrote: > The N5X platform has the Synopsys DDR controller the includes an EDAC > controller. Add the entry for the controller in the DTS file instead of > the base Agilex DTSI because the base Agilex does not have the > controller. > > Signed-off-by: Dinh Nguyen > --- > arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts > index f3c1310dae0a..628c9943914b 100644 > --- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts > +++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts > @@ -23,6 +23,16 @@ memory { > /* We expect the bootloader to fill in the reg */ > reg = <0 0 0 0>; > }; > + > + soc { > + sdram_edac: sdr_edac@f87f8000 { This patch was merged but it is not correct. The node name should be memory-controller (generic, not specific). > + compatible = "snps,ddrc-3.80a"; > + reg = <0xf87f8000 0x400>; > + interrupts = <0 175 4>; This fails dt schema. > + intel,sysmgr-syscon = <&sysmgr 0xb8>; This fails schema even more... it's not documented. > + status = "okay"; This is not needed. Please test your changes against bindings (you can use dtbs_check). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel