From: Evgeniy Polyakov Subject: Re: [PATCH] connector: bump skb->users before callback invocation Date: Mon, 11 Jan 2016 23:03:22 +0300 Message-ID: <1218671452542602@web12j.yandex.ru> References: <20151231132633.GA30790@breakpoint.cc> <20160104.214733.921867451376206917.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "dvyukov@google.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: David Miller , "fw@strlen.de" Return-path: In-Reply-To: <20160104.214733.921867451376206917.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi everyone Thanks for fixing and quick pushing of this bug. 05.01.2016, 05:47, "David Miller" : > From: Florian Westphal > Date: Thu, 31 Dec 2015 14:26:33 +0100 > >> =9ADmitry reports memleak with syskaller program. >> =9AProblem is that connector bumps skb usecount but might not invoke= callback. >> >> =9ASo move skb_get to where we invoke the callback. >> >> =9AReported-by: Dmitry Vyukov >> =9ASigned-off-by: Florian Westphal > > Applied and queued up for -stable, thanks.