Return-path: Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KUtOD-0007j4-ON for kexec@lists.infradead.org; Mon, 18 Aug 2008 01:18:33 +0000 Subject: Re: [PATCH -v3 6/7] kexec jump: __ftrace_enabled_save/restore From: Huang Ying In-Reply-To: <20080815124938.GB24663@elte.hu> References: <1218510876.24951.45.camel@caritas-dev.intel.com> <20080815124938.GB24663@elte.hu> Date: Mon, 18 Aug 2008 09:18:13 +0800 Message-Id: <1219022293.5663.14.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Ingo Molnar Cc: nigel@nigel.suspend2.net, Kexec Mailing List , linux-kernel@vger.kernel.org, Steven Rostedt , "Rafael J. Wysocki" , "Eric W. Biederman" , Pavel Machek , Andrew Morton , Linus Torvalds , Vivek Goyal On Fri, 2008-08-15 at 14:49 +0200, Ingo Molnar wrote: > * Huang Ying wrote: > > > +/* Ftrace disable/restore without lock. Some synchronization mechanism > > + * must be used to prevent ftrace_enabled to be changed between > > + * disable/restore. */ > > use the proper comment style please: > > /* > * > */ OK. I will change it. > > +static inline int __ftrace_enabled_save(void) > > +{ > > +#ifdef CONFIG_FTRACE > > + int saved_ftrace_enabled = ftrace_enabled; > > + ftrace_enabled = 0; > > + return saved_ftrace_enabled; > > +#else > > + return 0; > > +#endif > > +} > > + > > +static inline void __ftrace_enabled_restore(int enabled) > > +{ > > +#ifdef CONFIG_FTRACE > > + ftrace_enabled = enabled; > > +#endif > > +} > > hm, what is this used for? > > also, instead of such an ugly inline, why not create a proper > kernel/trace/* function for this. That would also give it access to all > the proper locking mechanisms - instead of relying on some extral > mechanism. This function is used for kexec jump in machine_kexec(). Where all non-boot CPUs and IRQ are disabled, system is going to kexec, and it is not allowed to schedule to other process in this circumstance, so a non-lock version is needed. A locked version has been implemented by Steven Rostedt, I think it can be used for other circumstance. Best Regards, Huang Ying _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec