From: Stelian Pop Date: Tue, 21 Oct 2008 18:54:31 +0200 Subject: [U-Boot] [PATCH] lcd: print custom strings after the logo In-Reply-To: <48FE06A2.8090507@ronetix.at> References: <48FDD4AA.40009@ronetix.at> <1224606181.6551.18.camel@galileo> <48FE06A2.8090507@ronetix.at> Message-ID: <1224608071.6551.30.camel@galileo> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le mardi 21 octobre 2008 ? 18:43 +0200, Ilko Iliev a ?crit : > >> +#ifndef CONFIG_LCD_LOGO_TEXT1 > >> +# define CONFIG_LCD_LOGO_TEXT1 "(C) 2008 ATMEL Corp" > >> +#endif > >> > > > > Wouldn't it be better if we move this text into > > include/configs/at91xxx.h for all the boards ? > > > Yes, it will be better. > Because I'm a newbie in the U-BOOT development I didn't want to make > changes in all boards. > I have also other suggestions: see my email for the lowlevel_init.S Yes, I saw them. Wolfgang proposed to use a weak function, which is probably way better > Do you know why the CPU registers are defined in this way: > #define AT91_PMC (0xfffffc00 - AT91_BASE_SYS) This is because the header files ware copied (with some editing) from Linux, and this is how Linux does define those register offsets. > This is OK for a C-code, but for an assembler it is a problem because > the following code gives an "Error: bad immediate value for offset": > ldr r1, =AT91_BASE_SYS You shouldn't do this. Look at at91_sys_read()/at91_sys_write() implementation. So the code should be: ldr r1, =(AT91_BASE_SYS + AT91_PMC) which will be optimised by cpp to: ldr r1, =0xfffffc00 Stelian. -- Stelian Pop