Subject: Re: [PATCH -v1 2/3] vm: use new has_capability_noaudit From: Eric Paris To: Stephen Smalley Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, jmorris@nameil.org, serue@us.ibm.com, morgan@kernel.org, casey@schaufler-ca.com, esandeen@redhat.com In-Reply-To: <1225307723.6588.119.camel@moss-spartans.epoch.ncsc.mil> References: <20081029190652.31292.5901.stgit@paris.rdu.redhat.com> <20081029190658.31292.10620.stgit@paris.rdu.redhat.com> <1225307723.6588.119.camel@moss-spartans.epoch.ncsc.mil> Content-Type: text/plain Date: Wed, 29 Oct 2008 15:57:07 -0400 Message-Id: <1225310227.23736.31.camel@localhost.localdomain> Mime-Version: 1.0 Sender: owner-selinux@tycho.nsa.gov List-Id: selinux@tycho.nsa.gov On Wed, 2008-10-29 at 15:15 -0400, Stephen Smalley wrote: > On Wed, 2008-10-29 at 15:06 -0400, Eric Paris wrote: > > The oomkiller calculations make decisions based on capabilities. Since > > these are not security decisions and LSMs should not record if they fall > > the request they should use the new has_capability_noaudit() interface so > > the denials will not be recorded. > > > > Signed-off-by: Eric Paris > > --- > > > > fs/proc/base.c | 2 +- > > mm/oom_kill.c | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fs/proc/base.c b/fs/proc/base.c > > index 486cf3f..ef83e81 100644 > > --- a/fs/proc/base.c > > +++ b/fs/proc/base.c > > @@ -1020,7 +1020,7 @@ static ssize_t oom_adjust_write(struct file *file, const char __user *buf, > > task = get_proc_task(file->f_path.dentry->d_inode); > > if (!task) > > return -ESRCH; > > - if (oom_adjust < task->oomkilladj && !capable(CAP_SYS_RESOURCE)) { > > + if (oom_adjust < task->oomkilladj && !has_capability_noaudit(current, CAP_SYS_RESOURCE)) { > > This one looks like an actual permission check to see whether the > current task is authorized to modify this value (by writing to some proc > node). Which should be audited. Unlike the others, where they are > checking whether some other task has a capability in order to help > decide priorities for the OOM killer. Will be fixed in -v2 -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with the words "unsubscribe selinux" without quotes as the message.