From: Mingming Cao Subject: [PATCH 1/2] QUOTA cleanup: Use inode->i_blkbits to get block bits Date: Mon, 10 Nov 2008 17:40:27 -0800 Message-ID: <1226367627.6352.13.camel@mingming-laptop> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Jan Kara , linux-fsdevel To: Andrew Morton Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:59633 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbYKKBka (ORCPT ); Mon, 10 Nov 2008 20:40:30 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mAB1e4NW030140 for ; Mon, 10 Nov 2008 18:40:04 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAB1eTbI151094 for ; Mon, 10 Nov 2008 18:40:29 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAB1e0HH008875 for ; Mon, 10 Nov 2008 18:40:00 -0700 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: quota: Use inode->i_blkbits to get block bits From: Mingming Cao Andrew has suggested to use inode->i_blkbits to get the block bits info, rather than use super block's blockbits. That should be faster and emit less code. Signed-off-by: Mingming Cao --- include/linux/quotaops.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6.28-rc2/include/linux/quotaops.h =================================================================== --- linux-2.6.28-rc2.orig/include/linux/quotaops.h 2008-11-07 11:23:00.000000000 -0800 +++ linux-2.6.28-rc2/include/linux/quotaops.h 2008-11-07 11:24:39.000000000 -0800 @@ -399,26 +399,26 @@ static inline void vfs_dq_free_space(str static inline int vfs_dq_prealloc_block_nodirty(struct inode *inode, qsize_t nr) { return vfs_dq_prealloc_space_nodirty(inode, - nr << inode->i_sb->s_blocksize_bits); + nr << inode->i_blkbits); } static inline int vfs_dq_prealloc_block(struct inode *inode, qsize_t nr) { return vfs_dq_prealloc_space(inode, - nr << inode->i_sb->s_blocksize_bits); + nr << inode->i_blkbits); } static inline int vfs_dq_alloc_block_nodirty(struct inode *inode, qsize_t nr) { return vfs_dq_alloc_space_nodirty(inode, - nr << inode->i_sb->s_blocksize_bits); + nr << inode->i_blkbits); } static inline int vfs_dq_alloc_block(struct inode *inode, qsize_t nr) { return vfs_dq_alloc_space(inode, - nr << inode->i_sb->s_blocksize_bits); + nr << inode->i_blkbits); } static inline int vfs_dq_reserve_block(struct inode *inode, qsize_t nr) @@ -441,12 +441,12 @@ void vfs_dq_release_reservation(struct i static inline void vfs_dq_free_block_nodirty(struct inode *inode, qsize_t nr) { - vfs_dq_free_space_nodirty(inode, nr << inode->i_sb->s_blocksize_bits); + vfs_dq_free_space_nodirty(inode, nr << inode->i_blkbits); } static inline void vfs_dq_free_block(struct inode *inode, qsize_t nr) { - vfs_dq_free_space(inode, nr << inode->i_sb->s_blocksize_bits); + vfs_dq_free_space(inode, nr << inode->i_blkbits); } /*