From: Harvey Harrison Date: Mon, 05 Jan 2009 22:59:24 +0000 Subject: Re: [PATCH] module: clean up initialization of variable Message-Id: <1231196364.11902.7.camel@brick> List-Id: References: <20090105181922.GA25622@uranus.ravnborg.org> <20090105195415.GA6204@uranus.ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: Sam Ravnborg , LKML , Steven Rostedt , Ingo Molnar , "David S. Miller" , sparclinux , Rusty Russell , Andrew Morton On Mon, 2009-01-05 at 15:30 -0500, Steven Rostedt wrote: > + hdr = vmalloc(len); > + if (hdr = NULL) A bit pedantic but, if (!hdr) perhaps? Cheers, Harvey