From: Ian Kent Subject: Re: [PATCH 4/4] Replace with Date: Mon, 12 Jan 2009 14:59:47 +0900 Message-ID: <1231739987.3073.78.camel@zeus.themaw.net> References: <1231526823-18595-1-git-send-email-vaurora@redhat.com> <1231526823-18595-2-git-send-email-vaurora@redhat.com> <1231526823-18595-3-git-send-email-vaurora@redhat.com> <1231526823-18595-4-git-send-email-vaurora@redhat.com> <1231526823-18595-5-git-send-email-vaurora@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1231526823-18595-5-git-send-email-vaurora@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autofs-bounces@linux.kernel.org Errors-To: autofs-bounces@linux.kernel.org To: Valerie Aurora Henson Cc: autofs@linux.kernel.org On Fri, 2009-01-09 at 13:47 -0500, Valerie Aurora Henson wrote: > If installed, just includes the user-level > string.h. If it's not installed, the compile fails. Right. This include file is also used by the kernel and I'd like to keep them the same. Maybe we need some #ifdef __KERNEL__ here as I think include will fail during a kernel build. Or maybe we need to move the include to fs/autofs4/dev-ioctl.c as I don't use any str* functions in the include file any more. > > From: Paul Wankadia > Signed-off-by: Valerie Aurora Henson > --- > include/linux/auto_dev-ioctl.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/auto_dev-ioctl.h b/include/linux/auto_dev-ioctl.h > index 91a7739..78f4b47 100644 > --- a/include/linux/auto_dev-ioctl.h > +++ b/include/linux/auto_dev-ioctl.h > @@ -10,7 +10,7 @@ > #ifndef _LINUX_AUTO_DEV_IOCTL_H > #define _LINUX_AUTO_DEV_IOCTL_H > > -#include > +#include > #include > > #define AUTOFS_DEVICE_NAME "autofs"