From: Ian Kent Subject: Re: [PATCH 1/4] Make hash table scale to thousands of entries Date: Tue, 13 Jan 2009 13:15:26 +0900 Message-ID: <1231820126.3057.14.camel@zeus.themaw.net> References: <1231526823-18595-1-git-send-email-vaurora@redhat.com> <1231526823-18595-2-git-send-email-vaurora@redhat.com> <20090109195151.GH32333@shell> <408431290901091719j58c33f8bj65ce1a47f782bc29@mail.gmail.com> <1231692176.10063.10.camel@zeus.themaw.net> <408431290901111525y578a5ba4n634ee8b071718790@mail.gmail.com> <1231723189.3073.7.camel@zeus.themaw.net> <1231732946.3073.44.camel@zeus.themaw.net> <1231736307.3073.68.camel@zeus.themaw.net> <408431290901121752x3e7c1ab6xa3d1cf711db5e2bb@mail.gmail.com> <1231813498.3057.12.camel@zeus.themaw.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1231813498.3057.12.camel@zeus.themaw.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: autofs-bounces@linux.kernel.org Errors-To: autofs-bounces@linux.kernel.org To: Paul Wankadia Cc: autofs@linux.kernel.org On Tue, 2009-01-13 at 11:24 +0900, Ian Kent wrote: > On Tue, 2009-01-13 at 12:52 +1100, Paul Wankadia wrote: > > > > > > The only question remaining is how large should we make the > > table. > > A size of around 4k will lead to a lot of wasted space for > > many common > > configurations (including configurations that have many map > > entries > > spread over several individual maps) but a size around 1k > > still gives > > fairly long chains for large maps. > > > > Suggestions? > > > > Perhaps you could make it configurable? > > Perhaps, but I don't think this is the sort of thing that should be > configurable so I'd prefer to make it a compile time option rather than > a run time configuration setting. I've changed my mind, ;), configurable it is with a default of 977. Ian