Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LMtXo-0000KX-54 for mharc-grub-devel@gnu.org; Tue, 13 Jan 2009 19:23:40 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMtXm-0000JQ-Fn for grub-devel@gnu.org; Tue, 13 Jan 2009 19:23:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMtXl-0000IO-Cg for grub-devel@gnu.org; Tue, 13 Jan 2009 19:23:38 -0500 Received: from [199.232.76.173] (port=58401 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMtXl-0000II-8e for grub-devel@gnu.org; Tue, 13 Jan 2009 19:23:37 -0500 Received: from c60.cesmail.net ([216.154.195.49]:33150) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LMtXk-0001nL-Rl for grub-devel@gnu.org; Tue, 13 Jan 2009 19:23:37 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Jan 2009 19:23:32 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 37C9D34C6D for ; Tue, 13 Jan 2009 19:36:06 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090113231059.GA26931@pina.cat> References: <20090113231059.GA26931@pina.cat> Content-Type: text/plain Date: Tue, 13 Jan 2009 19:23:30 -0500 Message-Id: <1231892610.2519.29.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-3.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fseek -> fseeko X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2009 00:23:38 -0000 On Wed, 2009-01-14 at 00:10 +0100, Carles Pina i Estany wrote: > Hello, > > I see in the ChangeLog that fseek() has been replaced by fseeko(). But > there still is one fseek in Grub2 that has not been changed. It's because grub-editenv.c appeared after the commit that eliminated fseek(). > As far as I > can understand by "mistake" (should not affect anything but ChangeLog > says, about fseek, for example: > > ------- > * util/grub-fstest.c (cmd_cmp): Use fseeko(), not fseek(). The > later is obsolete, potentially dangerous and sets a bad example. > ------- > > So better to replace it? It doesn't really matter when the offset is 0, but let's replace it to avoid further questions. > ChangeLog: > ---------- > 2008-14-01 Carles Pina i Estany > > * util/grub-editenv.c (main): Use fseeko(), not fseek(). The year is placed first to make the format unambiguous. Also, string comparison would work for dates. But only if the month follows the year. > Could someone commit it? Committed, a day before you posted the patch :-) Actually, you didn't post the patch. You posted the whole file. Be careful. -- Regards, Pavel Roskin