From: Nitin A Kamble Subject: Re: [userspace patch] exposing host cpuids to guest Date: Fri, 30 Jan 2009 11:40:32 -0800 Message-ID: <1233344437.27414.18.camel@mukti.sc.intel.com> References: <1233277976.28605.9.camel@mukti.sc.intel.com> <1233280448.28605.12.camel@mukti.sc.intel.com> <20090130105749.GC25998@amit-x200.pnq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "avi@redhat.com" , "kvm@vger.kernel.org" To: Amit Shah Return-path: Received: from mga02.intel.com ([134.134.136.20]:31453 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbZA3Tki (ORCPT ); Fri, 30 Jan 2009 14:40:38 -0500 In-Reply-To: <20090130105749.GC25998@amit-x200.pnq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2009-01-30 at 02:57 -0800, Amit Shah wrote: > Please split them into multiple patches; they do a lot of things here. > It's easier to review once all the logical changes are separated out. > > Also, split out the qemu-specific (qemu/target-i386/*) and kvm-specific > parts so that the qemu-specific ones can be sent upstream. ok, I will try to split all the patches like that. My Concern is, The code is inter-dependent, if all splits are not in then it may break the tree's functionality. I will try to group the split patches for that reason. Thanks & Regards, Nitin