From: Alex Williamson Subject: Re: [PATCH 0/4] qemu: TAP filtering support Date: Wed, 11 Feb 2009 13:37:19 -0700 Message-ID: <1234384639.7026.1533.camel@lappy> References: <20090210212841.9760.96780.stgit@kvm.aw> <1234380678.14052.238.camel@blaa> <1234381866.7026.1524.camel@lappy> <1234383541.14052.247.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:2245 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755538AbZBKUgm (ORCPT ); Wed, 11 Feb 2009 15:36:42 -0500 In-Reply-To: <1234383541.14052.247.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2009-02-11 at 20:19 +0000, Mark McLoughlin wrote: > On Wed, 2009-02-11 at 12:51 -0700, Alex Williamson wrote: > > > - What do we need rxfilter=on|off on the command line for? > > > > Primarily because the current tun driver in Linux has a bug that it can > > drop unicast packets requested to be included in the filter if it > > overflows the exact match table. > > > > http://www.spinics.net/lists/netdev/msg88451.html > > Oh dear. Does this suggest we should make rxfilter=off the default? > > Is there any way we can automatically detect we're running on a broken > kernel? TUNSETTXFITLER has only existed since 2.6.26, so the ioctl will fail on anything older and it will be disabled anyway. The patch will fix .29 and should get rolled into .28 stable, so we're looking at an exposure of 2 kernel releases. Unfortunately a few community distros went out on those kernels, so perhaps the prudent approach would be to make the default disabled until we're a few releases beyond. I don't know any way you could detect it outside of ugly parsing of uname -r. Thanks, Alex