From: jamal Subject: [PATCH] libxtables: Dont initialize global xt_params Date: Thu, 12 Feb 2009 09:16:02 -0500 Message-ID: <1234448162.3271.1.camel@dogo.mojatatu.com> Reply-To: hadi@cyberus.ca Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Jan Engelhardt , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail-ew0-f21.google.com ([209.85.219.21]:48717 "EHLO mail-ew0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755237AbZBLOZy (ORCPT ); Thu, 12 Feb 2009 09:25:54 -0500 Received: by ewy14 with SMTP id 14so609668ewy.13 for ; Thu, 12 Feb 2009 06:25:52 -0800 (PST) Sender: netfilter-devel-owner@vger.kernel.org List-ID: commit 7aad144ecaf7603b17af5372886fe491c3bc6a2f Author: Jamal Hadi Salim Date: Wed Feb 11 16:19:30 2009 -0500 Dont initialize global xt_params To quote Jan Engelhardt " Do not initialize static members - this takes up extra space and adds no benefit. (zeroed anyway even in .bss) " Signed-off-by: Jamal Hadi Salim diff --git a/xtables.c b/xtables.c index 8e28d5e..114a393 100644 --- a/xtables.c +++ b/xtables.c @@ -48,7 +48,7 @@ void basic_exit_err(enum xtables_exittype status, const char *msg, ...) __attribute__((noreturn, format(printf,2,3))); -struct xtables_globals *xt_params = NULL; +struct xtables_globals *xt_params; void basic_exit_err(enum xtables_exittype status, const char *msg, ...) {