From: Benjamin Herrenschmidt Date: Sat, 28 Feb 2009 21:09:39 +0000 Subject: Re: [PATCH 2/2] x86-64: seccomp: fix 32/64 syscall hole Message-Id: <1235855379.7388.113.camel@pasglop> List-Id: References: <20090228030226.C0D34FC3DA@magilla.sf.frob.com> <20090228030413.5B915FC3DA@magilla.sf.frob.com> <20090228072554.CFEA6FC3DA@magilla.sf.frob.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Torvalds Cc: Roland McGrath , linux-mips@linux-mips.org, x86@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, Andrew Morton , stable@kernel.org On Sat, 2009-02-28 at 09:23 -0800, Linus Torvalds wrote: > > On Fri, 27 Feb 2009, Roland McGrath wrote: > > > > I don't know any other arch well enough to be sure that TIF_32BIT isn't the > > wrong test there too. I'd like to leave that worry to the arch maintainers. > > Agreed - it may be that others will want to not use TIF_32BIT too. It > really does make much more sense to have it as a thread-local status flag > than as an atomic (and thus expensive to modify) thread-flag, not just on > x86. FYI. _TIF_32BIT is the right test on powerpc (it's also what entry_64.S tests to pick the appropriate syscall table). Cheers, Ben.