From: simo Subject: Re: [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call Date: Wed, 04 Mar 2009 14:24:30 -0500 Message-ID: <1236194670.22692.0.camel@pico.li.ssimo.org> References: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel , samba-technical , "linux-cifs-client@lists.samba.org" , Jeff Layton To: Steve French Return-path: In-Reply-To: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org Errors-To: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2009-03-04 at 13:02 -0600, Steve French wrote: > Attached is patch to workaround the problem found in posix open to > Samba versions 3.3.1 and earlier > (create works, but open would fail with invalid parameter) - it > disables requests to try posix open after > a first failure. Why do you completely disable posix opens ? Wouldn't it make sense to reopen only when it fails ? After all when you create new files it works correctly. Simo. -- Simo Sorce Samba Team GPL Compliance Officer Principal Software Engineer at Red Hat, Inc.