From: Peter Tyser Date: Fri, 13 Mar 2009 15:05:39 -0500 Subject: [U-Boot] [PATCH 17/26 v2] tools/Makefile: Give precedence to U-Boot's include directory In-Reply-To: <2acbd3e40903121702m22cee218tca9113328702712f@mail.gmail.com> References: <1236887355-31359-1-git-send-email-ptyser@xes-inc.com> <1236887355-31359-17-git-send-email-ptyser@xes-inc.com> <1236887355-31359-18-git-send-email-ptyser@xes-inc.com> <200903121901.23433.vapier@gentoo.org> <20090312231935.3E64A832E8B8@gemini.denx.de> <1236902033.17861.54.camel@localhost.localdomain> <2acbd3e40903121702m22cee218tca9113328702712f@mail.gmail.com> Message-ID: <1236974739.4025.60.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2009-03-12 at 19:02 -0500, Andy Fleming wrote: > On Thu, Mar 12, 2009 at 6:53 PM, Peter Tyser wrote: > > On Fri, 2009-03-13 at 00:19 +0100, Wolfgang Denk wrote: > >> Dear Mike Frysinger, > >> > >> In message <200903121901.23433.vapier@gentoo.org> you wrote: > >> > > >> > On Thursday 12 March 2009 15:49:06 Peter Tyser wrote: > >> > > Update include search path so that the includes in U-Boot's include/ > >> > > directory have precedence over system includes. This allows crc32.c > >> > > to use U-Boot's zlib.h header which removes the previously required > >> > > symlinked zlib.h. > >> > > >> > this seems pretty risky. the headers in include/ are pretty much for u-boot. > >> > making those with the host headers seems like it's doomed to failure. > >> > >> Indeed. > >> > >> Full NAK from me, too. > > > > So what's a good fix? U-Boot's crc32() prototype uses uint32_t while > > the standard zlib uses ulongs (It looks like Mike tried to keep U-Boot's > > zlib.h header in line with the standard zlib.h, but then resorted to > > using uint32_t's a year ago: > > http://www.mail-archive.com/u-boot-users at lists.sourceforge.net/msg03726.html ). Thanks Andy, that looks a lot cleaner and simpler. I'll resubmit the series shortly. Peter