From: Avi Kivity Subject: [PATCH] Fix crash on resolution change -> screen dump -> vga redraw Date: Tue, 7 Apr 2009 12:33:52 +0300 Message-ID: <1239096832-25757-1-git-send-email-avi@redhat.com> Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58643 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbZDGJe1 (ORCPT ); Tue, 7 Apr 2009 05:34:27 -0400 Sender: kvm-owner@vger.kernel.org List-ID: The vga screen dump function updates last_width and last_height, but does not change the DisplaySurface that these variables describe. A consequent vga_draw_graphic() will therefore fail to resize the surface and crash. Fix by invalidating the display state after a screen dump, forcing vga_draw_graphic() to reallocate the DisplaySurface. Signed-off-by: Avi Kivity --- hw/vga.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index b1e4373..4d1049b 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2678,4 +2678,5 @@ static void vga_screen_dump(void *opaque, const char *filename) vga_screen_dump_graphic(s, filename); else vga_screen_dump_text(s, filename); + vga_invalidate_display(s); } -- 1.6.0.6