Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ls20u-0006J5-67 for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 17:42:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls20s-0006In-1B for grub-devel@gnu.org; Thu, 09 Apr 2009 17:42:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls20n-0006I9-88 for grub-devel@gnu.org; Thu, 09 Apr 2009 17:42:21 -0400 Received: from [199.232.76.173] (port=51629 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls20n-0006I6-4B for grub-devel@gnu.org; Thu, 09 Apr 2009 17:42:17 -0400 Received: from e24smtp04.br.ibm.com ([32.104.18.25]:35525) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ls20m-0001VR-Ft for grub-devel@gnu.org; Thu, 09 Apr 2009 17:42:16 -0400 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp04.br.ibm.com (8.13.1/8.13.1) with ESMTP id n39LcEQC007575 for ; Thu, 9 Apr 2009 18:38:14 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n39LgV981490986 for ; Thu, 9 Apr 2009 18:42:31 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n39LgCcB010964 for ; Thu, 9 Apr 2009 18:42:12 -0300 Received: from [9.18.199.148] ([9.18.199.148]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n39LgB5C010952 for ; Thu, 9 Apr 2009 18:42:11 -0300 From: Manoel Rebelo Abranches To: The development of GRUB 2 In-Reply-To: <20090409.140518.193806903.davem@davemloft.net> References: <20090407.170326.53300776.davem@davemloft.net> <20090409.140518.193806903.davem@davemloft.net> Content-Type: text/plain Date: Thu, 09 Apr 2009 18:42:08 -0300 Message-Id: <1239313328.3478.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH]: grub: Fix ieee1275 call block typing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 21:42:22 -0000 At first it seems ok. I'll test it in the weekend ok? On Thu, 2009-04-09 at 14:05 -0700, David Miller wrote: > From: David Miller > Date: Tue, 07 Apr 2009 17:03:26 -0700 (PDT) > > > 2009-04-07 David S. Miller > > > > * disk/ieee1275/nand.c (grub_nand_open): All ieee1275 call arg > > slots are of type grub_ieee1275_cell_t. > > (grub_nand_read): Likewise. > > * kern/ieee1275/ieee1275.c (IEEE1275_PHANDLE_INVALID, > > IEEE1275_IHANDLE_INVALID): Use grub_ieee1275_cell_t since these > > macros are used to compare values in arg/ret block of the call. > > (grub_ieee1275_finddevice, grub_ieee1275_get_property, > > grub_ieee1275_next_property, grub_ieee1275_get_property_length, > > grub_ieee1275_instance_to_package, grub_ieee1275_package_to_path, > > grub_ieee1275_instance_to_path, grub_ieee1275_write, > > grub_ieee1275_read, grub_ieee1275_seek, grub_ieee1275_peer, > > grub_ieee1275_child, grub_ieee1275_parent, grub_ieee1275_open, > > grub_ieee1275_close, grub_ieee1275_set_property, > > grub_ieee1275_set_color): All ieee1275 call arg slots are of type > > grub_ieee1275_cell_t. > > * kern/ieee1275/openfw.c (grub_map): Likewise. > > * include/grub/ieee1275/ieee1275.h (grub_ieee1275_ihandle_t, > > grub_ieee1275_phandle_t): Define as grub_unit32_t type. > > Ping? I'm touching non-sparc code so at least one review would > be appreciated before I check this in. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Best Regards, Manoel Rebelo Abranches IBM Linux Technology Center Brazil