From: Peter Tyser Date: Mon, 27 Apr 2009 17:52:33 -0500 Subject: [U-Boot] [PATCH/next v3 27/28] Add support for building native win32 tools In-Reply-To: <20090427224122.D3ECF83420E8@gemini.denx.de> References: <1236988492-21295-1-git-send-email-ptyser@xes-inc.com> <1236988492-21295-2-git-send-email-ptyser@xes-inc.com> <1236988492-21295-3-git-send-email-ptyser@xes-inc.com> <1236988492-21295-4-git-send-email-ptyser@xes-inc.com> <1236988492-21295-5-git-send-email-ptyser@xes-inc.com> <1236988492-21295-6-git-send-email-ptyser@xes-inc.com> <1236988492-21295-7-git-send-email-ptyser@xes-inc.com> <1236988492-21295-8-git-send-email-ptyser@xes-inc.com> <1236988492-21295-9-git-send-email-ptyser@xes-inc.com> <1236988492-21295-10-git-send-email-ptyser@xes-inc.com> <1236988492-21295-11-git-send-email-ptyser@xes-inc.com> <1236988492-21295-12-git-send-email-ptyser@xes-inc.com> <1236988492-21295-13-git-send-email-ptyser@xes-inc.com> <1236988492-21295-14-git-send-email-ptyser@xes-inc.com> <1236988492-21295-15-git-send-email-ptyser@xes-inc.com> <1236988492-21295-16-git-send-email-ptyser@xes-inc.com> <1236988492-21295-17-git-send-email-ptyser@xes-inc.com> <1236988492-21295-18-git-send-email -ptyser@xes-inc.com> <1236988492-21295-19-git-send-email-ptyser@xes-inc.com> <1236988492-21295-20-git-send-email-ptyser@xes-inc.com> <1236988492-21295-21-git-send-email-ptyser@xes-inc.com> <1236988492-21295-22-git-send-email-ptyser@xes-inc.com> <1236988492-21295-23-git-send-email-ptyser@xes-inc.com> <1236988492-21295-24-git-send-email-ptyser@xes-inc.com> <1236988492-21295-25-git-send-email-ptyser@xes-inc.com> <1236988492-21295-26-git-send-email-ptyser@xes-inc.com> <1236988492-21295-27-git-send-email-ptyser@xes-inc.com> <1236988492-21295-28-git-send-email-ptyser@xes-inc.com> <20090403232058.A750083797DC@gemini.denx.de> <1239749550.24099.147.camel@localhost.localdomain> <20090427224122.D3ECF83420E8@gemini.denx.de> Message-ID: <1240872753.11057.53.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, > > #1 is ugly in that 99.99% of the time an empty os_support.c file is > > processed. > > > > #2 is ugly in that the Makefile method to determine a target OS is > > somewhat hokey and will only get hokier if/when additional OS targets > > are supported. > > > > I'd vote for #1 as I think the wasted time of processing os_support.c is > > a drop in the bucket and it seems a bit cleaner than hacking up the > > Makefile. > > > > If others have any clever ideas let me know. > > It seems there were no really clever ideas, or did I miss them? > > Hm.. actually I lost track of which patch is missing. Could you please > send me a pointer to the latest and greatest version? Sorry & thanks. The original v3 of "Add support for building native win32 tools" has actually been merged already. After merging the patch, you had requested a cleanup patch to which I responded with the patch's rationale as well as a possible (in my opinion) dirtier cleanup. No one else suggested a cleaner way to implement the change, so what is currently committed should be correct. I'm still open to clever ideas if anyone has one though:) Thanks, Peter