From: Daniel Ribeiro Subject: pxa2xx_spi: prevent panic case setup() fails Date: Fri, 08 May 2009 11:11:44 -0300 Message-ID: <1241791904.10342.44.camel@brutus> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: David Brownell , Ned Forrester , openezx-devel , linux-arm-kernel , spi-devel-general To: Eric Miao Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openezx-devel-bounces@lists.openezx.org Errors-To: openezx-devel-bounces@lists.openezx.org List-Id: linux-spi.vger.kernel.org setup() may fail before ctldata is set, causing a kernel panic on cleanup(). Signed-off-by: Daniel Ribeiro diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c index 885194a..2801307 100644 --- a/drivers/spi/pxa2xx_spi.c +++ b/drivers/spi/pxa2xx_spi.c @@ -1373,6 +1373,9 @@ static void cleanup(struct spi_device *spi) { struct chip_data *chip = spi_get_ctldata(spi); + if (!chip) + return; + if (gpio_is_valid(chip->gpio_cs)) gpio_free(chip->gpio_cs); -- Daniel Ribeiro