From: Wolfgang Denk Date: Fri, 15 May 2009 09:27:58 +0200 Subject: [U-Boot] [PATCH v3] IDE: bail out of dev_print() for unknown device types In-Reply-To: <200905150727.09965.sr@denx.de> References: <200905150727.09965.sr@denx.de> Message-ID: <1242372478-8446-1-git-send-email-wd@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Commit 574b319512 introduced a subtle bug by mixing a list of tests for "dev_desc->type" and "dev_desc->if_type" into one switch(), which then mostly did not work because "dev_desc->type" cannot take any "IF_*" type values. A later fix in commit 8ec6e332ea changed the switch() into testing "dev_desc->if_type", but at this point the initial test for unknown device types was completely lost, which resulted in output like that for IDE ports without device attached: Device 1: Model: Firm: Ser#: Type: # 1F # Capacity: not available This patch re-introduces the missing test for unknown device types. Signed-off-by: Wolfgang Denk Cc: Stefan Roese Cc: Detlev Zundel --- v2: fix typo v3: fix white space disk/part.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/disk/part.c b/disk/part.c index c777493..b92fb45 100644 --- a/disk/part.c +++ b/disk/part.c @@ -114,6 +114,11 @@ void dev_print (block_dev_desc_t *dev_desc) lbaint_t lba512; #endif + if (dev_desc->type == DEV_TYPE_UNKNOWN) { + puts ("not available\n"); + return; + } + switch (dev_desc->if_type) { case IF_TYPE_SCSI: printf ("(%d:%d) Vendor: %s Prod.: %s Rev: %s\n", -- 1.6.0.6