From: Nitin A Kamble Subject: Re: [patch] VMX Unrestricted mode support Date: Mon, 01 Jun 2009 11:06:49 -0700 Message-ID: <1243879609.30052.1.camel@mukti.sc.intel.com> References: <1243552292.25456.23.camel@mukti.sc.intel.com> <4A224229.6090108@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from mga09.intel.com ([134.134.136.24]:64192 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbZFASGs (ORCPT ); Mon, 1 Jun 2009 14:06:48 -0400 In-Reply-To: <4A224229.6090108@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2009-05-31 at 01:39 -0700, Avi Kivity wrote: > Thanks, this is much needed. Review comments below. > > Please avoid hiding computations in macros. Just change the call sites. > Instead of changing all the checks like this, you can make rmode.active > be false when unrestricted guest is enabled. We can interpret > rmode.active as "emulating real mode via vm86", not as "guest is in real > mode". > > You can just have enter_rmode() exit immediately when called. > > I think this can go away if rmode.active == 0. > Avi, Thanks for your comments. I will cook another patch for this feature as per your comments. Thanks & Regards, Nitin