From: Mark Jackson Date: Thu, 04 Jun 2009 10:22:46 +0100 Subject: [U-Boot] Bug in at32ap portmux.c Message-ID: <1244107366.1999.3.camel@mpfj-x64> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In the latest git, I've just noticed what I guess is a typo in this code. void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) { .... /* REVISIT: Some pins are probably pure outputs */ portmux_select_peripheral(PORTMUX_PORT_D, portc_mask, PORTMUX_FUNC_B, PORTMUX_BUSKEEPER); portmux_select_peripheral(PORTMUX_PORT_C, portc_mask, PORTMUX_FUNC_B, PORTMUX_BUSKEEPER); } Both of these calls use the "portc_mask" variable, whereas the first call is setting PORTMUX_PORT_D. Should it be "portd_mask" in the first call ? Am I missing something or is this clearly wrong ??? Regards Mark