From: Subrata Modak Subject: Re: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Date: Wed, 10 Jun 2009 00:06:31 +0530 Message-ID: <1244572592.5497.35.camel@subratamodak.linux.ibm.com> References: <20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com> Reply-To: subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090605182651.24094.36577.sendpatchset-yA/sI1izFwLkOmf+N4b0O9FgqiXiwxn+0E9HWUfgJXw@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Brownell , Arnd Bergmann Cc: David Brownell , Sachin P Sant , Kumar Gala , Linux-Kernel , Randy Dunlap , Linux-Next , Jon Smirl , Linuxppc-dev , Roman Weissgaerber , Stephen Rothwell , kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org List-Id: linux-next.vger.kernel.org On Fri, 2009-06-05 at 13:26 -0500, Subrata Modak wrote: > >On Thu, 2009-06-04 at 10:07 -0400, Jon Smirl wrote: > >On Thu, Jun 4, 2009 at 9:31 AM, Subrata Modak > > wrote: > > > CC drivers/usb/host/ohci-hcd.o > > > In file included from drivers/usb/host/ohci-hcd.c:1060: > > > drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess selected for ppc-of-ohci" > > > make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1 > > > make[2]: *** [drivers/usb/host] Error 2 > > > make[1]: *** [drivers/usb] Error 2 > > > make: *** [drivers] Error 2 > > > > > > I reported this earlier, and there were some discussions: > > > http://groups.google.co.kr/group/linux.kernel/browse_thread/thread/edff9d5572d3d225 > > > > Proposed patch by Arnd should fix this. It has not been merged. > > http://lkml.org/lkml/2009/4/22/49 > > Correct, it fixes the issue. However, since few changes might have gone > to the Kconfig, the patch does not apply cleanly. Below is the patch, just > a retake of the earlier one, but on the latest code. > > David, > > Can you please pickup the following patch ? David, Is it you who will be merging this patch. Or, do i need to send it to somebody else ? Regards-- Subrata > > Signed-off-by: Arnd Bergmann , > Resent-by: Subrata Modak > --- > > --- linux-2.6.30-rc8/drivers/usb/host/Kconfig.orig 2009-06-05 10:31:30.000000000 -0500 > +++ linux-2.6.30-rc8/drivers/usb/host/Kconfig 2009-06-05 10:37:53.000000000 -0500 > @@ -181,26 +181,26 @@ config USB_OHCI_HCD_PPC_SOC > Enables support for the USB controller on the MPC52xx or > STB03xxx processor chip. If unsure, say Y. > > -config USB_OHCI_HCD_PPC_OF > - bool "OHCI support for PPC USB controller on OF platform bus" > - depends on USB_OHCI_HCD && PPC_OF > - default y > - ---help--- > - Enables support for the USB controller PowerPC present on the > - OpenFirmware platform bus. > - > config USB_OHCI_HCD_PPC_OF_BE > - bool "Support big endian HC" > - depends on USB_OHCI_HCD_PPC_OF > - default y > + bool "OHCI support for OF platform bus (big endian)" > + depends on USB_OHCI_HCD && PPC_OF > select USB_OHCI_BIG_ENDIAN_DESC > select USB_OHCI_BIG_ENDIAN_MMIO > + ---help--- > + Enables support for big-endian USB controllers present on the > + OpenFirmware platform bus. > > config USB_OHCI_HCD_PPC_OF_LE > - bool "Support little endian HC" > - depends on USB_OHCI_HCD_PPC_OF > - default n > + bool "OHCI support for OF platform bus (little endian)" > + depends on USB_OHCI_HCD && PPC_OF > select USB_OHCI_LITTLE_ENDIAN > + ---help--- > + Enables support for little-endian USB controllers present on the > + OpenFirmware platform bus. > + > + config USB_OHCI_HCD_PPC_OF > + bool > + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE > > config USB_OHCI_HCD_PCI > bool "OHCI support for PCI-bus USB controllers" > > --- > Regards-- > Subrata > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html