From: Subrata Modak Subject: Re: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Date: Mon, 15 Jun 2009 12:21:18 +0530 Message-ID: <1245048679.5239.8.camel@subratamodak.linux.ibm.com> References: <20090605182651.24094.36577.sendpatchset@elm3a191.beaverton.ibm.com> <200906091738.58154.david-b@pacbell.net> <1244799348.5234.13.camel@subratamodak.linux.ibm.com> Reply-To: subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1244799348.5234.13.camel-NRFfyExJdYpgXGGE5LP+UZlqa2bBAFbm0E9HWUfgJXw@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Brownell Cc: Arnd Bergmann , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sachin P Sant , Kumar Gala , Linux-Kernel , Randy Dunlap , Linux-Next , Jon Smirl , Linuxppc-dev , Stephen Rothwell , kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org List-Id: linux-next.vger.kernel.org On Fri, 2009-06-12 at 15:05 +0530, Subrata Modak wrote:=20 > On Tue, 2009-06-09 at 17:38 -0700, David Brownell wrote: > > On Friday 05 June 2009, Subrata Modak wrote: > > > Correct, it fixes the issue. However, since few changes might hav= e gone > > > to the Kconfig, the patch does not apply cleanly. Below is the pa= tch, just > > > a retake of the earlier one, but on the latest code.=20 > >=20 > > And it got mangled a bit along the way. Plus, the original one > > goofed up Kconfig dependency displays ... both issues fixed in > > this version, against current mainline GIT. > >=20 > > If someone can verify all four PPC/OF/OHCI configs build on > > on PPC64, I'm OK with it. > >=20 > > - Dave >=20 > Dave, >=20 > Sorry for being late. The patch fixes the issue on the latest git for > PPC64. Infact, the whole drivers/usb/host/ builds just fine: >=20 > linux-2.6 # make drivers/usb/host/ > CHK include/linux/version.h > CHK include/linux/utsrelease.h > SYMLINK include/asm -> include/asm-powerpc > CALL scripts/checksyscalls.sh > CC drivers/usb/host/ohci-hcd.o > CC drivers/usb/host/pci-quirks.o > CC drivers/usb/host/uhci-hcd.o > LD drivers/usb/host/built-in.o > CC [M] drivers/usb/host/isp116x-hcd.o > CC [M] drivers/usb/host/u132-hcd.o >=20 > You can check in the patch now. Dave, Have you checked in this patch ? Or, does it require some more modification/updates from somebody=C2=B4s side ? Regards-- Subrata >=20 > Regards-- > Subrata >=20 > >=20 > >=20 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D CUT HERE > > From: Arnd Bergmann > > Subject: fix build failure for PPC64 randconfig [usb/ohci] > >=20 > > We could just make the USB_OHCI_HCD_PPC_OF option implicit > > and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE > > and USB_OHCI_HCD_PPC_OF_LE are set. > >=20 > > [ dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org: fix patch manglation and depende= ncies ] > >=20 > > Signed-off-by: Arnd Bergmann > > Resent-by: Subrata Modak > > Signed-off-by: David Brownell > > --- > > drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- > > 1 file changed, 15 insertions(+), 14 deletions(-) > >=20 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC > > Enables support for the USB controller on the MPC52xx or > > STB03xxx processor chip. If unsure, say Y. > >=20 > > -config USB_OHCI_HCD_PPC_OF > > - bool "OHCI support for PPC USB controller on OF platform bus" > > - depends on USB_OHCI_HCD && PPC_OF > > - default y > > - ---help--- > > - Enables support for the USB controller PowerPC present on the > > - OpenFirmware platform bus. > > - > > config USB_OHCI_HCD_PPC_OF_BE > > - bool "Support big endian HC" > > - depends on USB_OHCI_HCD_PPC_OF > > - default y > > + bool "OHCI support for OF platform bus (big endian)" > > + depends on USB_OHCI_HCD && PPC_OF > > select USB_OHCI_BIG_ENDIAN_DESC > > select USB_OHCI_BIG_ENDIAN_MMIO > > + ---help--- > > + Enables support for big-endian USB controllers present on the > > + OpenFirmware platform bus. > >=20 > > config USB_OHCI_HCD_PPC_OF_LE > > - bool "Support little endian HC" > > - depends on USB_OHCI_HCD_PPC_OF > > - default n > > + bool "OHCI support for OF platform bus (little endian)" > > + depends on USB_OHCI_HCD && PPC_OF > > select USB_OHCI_LITTLE_ENDIAN > > + ---help--- > > + Enables support for little-endian USB controllers present on th= e > > + OpenFirmware platform bus. > > + > > +config USB_OHCI_HCD_PPC_OF > > + bool > > + depends on USB_OHCI_HCD && PPC_OF > > + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE > >=20 > > config USB_OHCI_HCD_PCI > > bool "OHCI support for PCI-bus USB controllers" > >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html