Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHOFn-0002qf-SV for mharc-grub-devel@gnu.org; Thu, 18 Jun 2009 16:30:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHOFm-0002pR-9u for grub-devel@gnu.org; Thu, 18 Jun 2009 16:30:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHOFh-0002iZ-QR for grub-devel@gnu.org; Thu, 18 Jun 2009 16:30:33 -0400 Received: from [199.232.76.173] (port=55443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHOFh-0002iI-H1 for grub-devel@gnu.org; Thu, 18 Jun 2009 16:30:29 -0400 Received: from c60.cesmail.net ([216.154.195.49]:15357) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MHOFh-00038j-0c for grub-devel@gnu.org; Thu, 18 Jun 2009 16:30:29 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 18 Jun 2009 16:30:27 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 7B38834C6D for ; Thu, 18 Jun 2009 16:36:01 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20090612204549.12859.42374.stgit@mj.roinet.com> <1245111326.11728.27.camel@mj> <1245175778.1926.17.camel@mj> Content-Type: text/plain Date: Thu, 18 Jun 2009 16:30:25 -0400 Message-Id: <1245357025.27523.1.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Remove root drive support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2009 20:30:34 -0000 On Thu, 2009-06-18 at 18:57 +0200, Vladimir 'phcoder' Serbinenko wrote: > Update copyright year. Done. > I suggest putting new id in grub_disk_dev_id to the end. Done. Actually, using modules compiled from different sources is asking for trouble, but it's not like this list is well sorted now. > You also forgot to add it to grub-emu. Actually, I didn't add it because fs_uuid.c is not compiled for grub-emu. If you want, you can add them both. > Under qemu it worked well except that it wasn't autoloaded but I > looked and seen that we have no module autoloading for device drivers, > perhaps because some of them don't coexist well. We'll need a list of drive names with corresponding modules, something like: hd: biosdisk fd: biosdisk FILE=: fs_file UUID=: fs_uuid ata: ata It's true that autoloading of ata may break biosdisk. But nobody is forces to use ata devices on the command line. but it is becomes an issue, ata could be excluded from that list. > Except issues mentioned patch looks fine and I think you can commit it > even if we don't have userspace part yet Committed. -- Regards, Pavel Roskin