From: =?ISO-8859-1?Q?Andr=E9?= Schwarz Date: Mon, 22 Jun 2009 11:57:34 +0200 Subject: [U-Boot] show_boot_progess @ ppc not working In-Reply-To: <493F6F45.5060205@invitel.hu> References: <493E4FD6.4000803@matrix-vision.de> <493F6F45.5060205@invitel.hu> Message-ID: <1245664654.4216.34.camel@swa-m460> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Heiko, this issue looks still unfixed and is somewhat annoying. Im unable to use show_boot_progress with this weak definition in include/common.h. Simply re-defining the prototype in my local repo is not reasonable. How did you solve it ? Regards, Andr?? On Wed, 2008-12-10 at 08:27 +0100, Heiko Schocher wrote: > Hello Andre, > > Andre Schwarz wrote: > > All, > > > > can someone tell me why the board specific function "void > > show_boot_progress(int arg)" > > is no longer called (at least on MPC5200). > > > > Of course this line is present in the board config : > > > > #define CONFIG_SHOW_BOOT_PROGRESS 1 > > > > > > What have I missed ? > > > > Nothing! Good catch. I tried it on a mpc8xx and > on a mpx82xx based board and it also didnt worked :-( > > Can you try the following patch? (This patch solved it > on my boards ...) > > thanks, > Heiko > > [PATCH] all platforms: make show_boot_progress () again working. > > Signed-off-by: Heiko Schocher > --- > include/common.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/common.h b/include/common.h > index 5968036..6583f00 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -693,7 +693,7 @@ int pcmcia_init (void); > /* > * Board-specific Platform code can reimplement show_boot_progress () > if needed > */ > -void __attribute__((weak)) show_boot_progress (int val); > +void show_boot_progress (int val); > > #ifdef CONFIG_INIT_CRITICAL > #error CONFIG_INIT_CRITICAL is deprecated! MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich