From: Ben Skeggs Subject: Re: [PATCH] drm/nv50: wait for fifo completion when needed Date: Fri, 03 Jul 2009 07:52:46 +1000 Message-ID: <1246571566.2709.2.camel@nisroch> References: <20090702220653.GA16347@tchanem> <6d4bc9fc0907021420i42f22fe4p751e7f5181085b9d@mail.gmail.com> Reply-To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6d4bc9fc0907021420i42f22fe4p751e7f5181085b9d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Maarten Maathuis Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Thu, 2009-07-02 at 23:20 +0200, Maarten Maathuis wrote: > This smells like taping over a bigger issue imo. The only reason the > old code did this because it didn't have interrupts to signal clock > changes (and such). I have no other solution, nor personal experience, > because i've been away (and still am). I just want to give my 2 cents. I agree, this really should not be required. The display channel should stall on its own until the appropriate IRQs have been handled, if required. It might be useful to know *which* of these "fixes" the issue to track down the real problem. Ben. > > Maarten. > _______________________________________________ > Nouveau mailing list > Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > http://lists.freedesktop.org/mailman/listinfo/nouveau