From: David Woodhouse Subject: Re: Re: [RFC] Make AGP work with IOMMU Date: Wed, 05 Aug 2009 08:08:51 +0100 Message-ID: <1249456131.9324.332.camel@macbook.infradead.org> References: <1248707041.6100.35.camel@macbook.infradead.org> <21d7e9970907282328l4a44b9a2of4500c5c84a3586b@mail.gmail.com> <1248851712.19733.214.camel@macbook.infradead.org> <21d7e9970907290143q6778511cvda1c6b915f61654a@mail.gmail.com> <1248860205.19733.238.camel@macbook.infradead.org> <4A78C9C6.6010103@goop.org> <1249454696.9324.325.camel@macbook.infradead.org> <21d7e9970908042357m6080e88fyeaaad171888766f2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21d7e9970908042357m6080e88fyeaaad171888766f2@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dave Airlie Cc: Jeremy Fitzhardinge , xen-devel@lists.xensource.com, Zhenyu Wang , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Keir Fraser List-Id: xen-devel@lists.xenproject.org On Wed, 2009-08-05 at 16:57 +1000, Dave Airlie wrote: > On Wed, Aug 5, 2009 at 4:44 PM, David Woodhouse wrote: > > On Tue, 2009-08-04 at 16:52 -0700, Jeremy Fitzhardinge wrote: > >> And just when I have patches to use them for their original purpose... > >> > >> Looking back over the thread, are you saying that most users are already > >> using the DMA API correctly for AGP accesses? If that's true then we > >> should be just fine. > > > > No, not 'most users'. But perhaps we should. > > > > All we've done so far is make intel-agp use the DMA API correctly. And > > that's conditional on CONFIG_DMAR. But we could make it unconditional, > > and make the other drivers do it too. The code is all fairly generic. > > > > Without an IOMMU, the overhead would be fairly minimal. > > > > I'm not sure how prevalent Xen is on AGP systems, I'm going to guess > not enough that anyone cares. Intel integrated chips are the only AGP > codebase user that are made any more, and they don't really use AGP > its just a legacy of the previous designs. On the other hand, extending the existing code so that it uses the DMA API correctly _unconditionally_ rather than only for the Intel driver would be fairly simple and should be harmless... -- dwmw2