From: Andrew Jones Subject: Re: [PATCH v2][xend] save/restore cpu_weight and cpu_cap Date: Wed, 05 Aug 2009 17:05:23 +0200 Message-ID: <1249484723.3323.21.camel@turtle.usersys.redhat.com> References: <1249040776.3750.13.camel@turtle.usersys.redhat.com> <1249043821.3750.20.camel@turtle.usersys.redhat.com> <18CA13DBCD74A1kanno.masaki@jp.fujitsu.com> <1249479281.3323.9.camel@turtle.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1249479281.3323.9.camel@turtle.usersys.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Masaki Kanno Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi Kan, I just caught up on my mail and see that you've submitted a patch that reverts most of 19955 due to the redundant domctl calls after putting in this patch - changeset 20006. That works too. Andrew On Wed, 2009-08-05 at 15:34 +0200, Andrew Jones wrote: > Hi Kan, > > Thanks for catching my mess-up. It looks like I messed-up and didn't > test on the tip. So I completely missed changeset 19955, which corrects > the exact same issue I was attempting to correct. Please disregard my > patch submittal. > > Andrew > > > On Mon, 2009-08-03 at 10:43 +0900, Masaki Kanno wrote: > > Fri, 31 Jul 2009 14:37:01 +0200, Andrew Jones wrote: > > > > >Argh... I shouldn't cut+paste patches into email editors. Sending again > > >without allowing evil auto-wrap to mess with it. > > > > > > > Hi Andrew, > > > > Without your patch, I can save/restore cpu_weight and cpu_cap as follows. > > > > # xm create vm1 cpu_weight=512 cpu_cap=100 > > Using config file "/etc/xen/vm1". > > Started domain vm1 (id=1) > > # xm sched-credit -d vm1 > > Name ID Weight Cap > > vm1 1 512 100 > > # xm list --long vm1 | grep cpu_ > > (cpu_weight 512) > > (cpu_cap 100) > > (cpu_time 22.504581706) > > # xm save vm1 /root/vm1.save > > # xm restore /root/vm1.save > > # xm sched-credit -d vm1 > > Name ID Weight Cap > > vm1 2 512 100 > > # xm list --long vm1 | grep cpu_ > > (cpu_weight 512) > > (cpu_cap 100) > > (cpu_time 2.200074199) > > > > > > What is your problem? > > How can I reproduce your problem? > > > > FYI, can changeset 19955 help you? > > > > Best regards, > > Kan > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel