From: Peter Tyser <ptyser@xes-inc.com>
Date: Thu, 13 Aug 2009 09:38:06 -0500
Subject: [U-Boot] [PATCH] V3 Add support for the galaxy5200
In-Reply-To: <20090813130918.M25061@coldhaus.com>
References: <20090813130918.M25061@coldhaus.com>
Message-ID: <1250174286.5873.4978.camel@localhost.localdomain>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

The title should be "[PATCH V3] ...", not "[PATCH] V3 ...".

On Thu, 2009-08-13 at 08:13 -0500, Eric Millbrandt wrote:
> Removed trailing whitespace introduced in V2 to conform with U-Boot coding style.
> Defined additional chip select region.

This should all go below the "---" below.

> Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
> ---

Comments that shouldn't be committed go here.

>  MAINTAINERS                   |    4 +
>  MAKEALL                       |    1 +
>  Makefile                      |    6 +
>  board/galaxy5200/Makefile     |   50 +++++
>  board/galaxy5200/config.mk    |   45 +++++
>  board/galaxy5200/galaxy5200.c |  199 +++++++++++++++++++
>  include/configs/galaxy5200.h  |  428 +++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 733 insertions(+), 0 deletions(-)
>  create mode 100644 board/galaxy5200/Makefile
>  create mode 100644 board/galaxy5200/config.mk
>  create mode 100644 board/galaxy5200/galaxy5200.c
>  create mode 100644 include/configs/galaxy5200.h

To be explicit, your patch should look like this:


[PATCH V4] Add support for the galaxy5200

Add support for the DEKA Research and Development galaxy5200 board

<A description of the galaxy5200 might be nice here too FWIW>

Signed-off-by: Eric Millbrandt <emillbrandt@dekaresearch.com>
---

Changes since v1:
- Amended with comments from Wolfgang
- Make change to top level makefile per Wolfgang's suggestion.

Changes since v2:
- Defined additional chip select region.

Changes since v3:
- Fixed up patch title and commit message per Peter's suggestion.

 MAINTAINERS                   |    4 +
 MAKEALL                       |    1 +
 Makefile                      |    6 +
 board/galaxy5200/Makefile     |   50 +++++
 board/galaxy5200/config.mk    |   45 +++++
 board/galaxy5200/galaxy5200.c |  199 +++++++++++++++++++
 include/configs/galaxy5200.h  |  428
+++++++++++++++++++++++++++++++++++++++++
 7 files changed, 733 insertions(+), 0 deletions(-)
 create mode 100644 board/galaxy5200/Makefile
 create mode 100644 board/galaxy5200/config.mk
 create mode 100644 board/galaxy5200/galaxy5200.c
 create mode 100644 include/configs/galaxy5200.h

...

Best,
Peter