From: Peter Tyser Date: Fri, 04 Sep 2009 17:57:48 -0500 Subject: [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable In-Reply-To: <20090904215900.62178832E8DE@gemini.denx.de> References: <1252099715-19255-1-git-send-email-timur@freescale.com> <20090904215900.62178832E8DE@gemini.denx.de> Message-ID: <1252105068.6005.160.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2009-09-04 at 23:59 +0200, Wolfgang Denk wrote: > Dear Timur Tabi, > > In message <1252099715-19255-1-git-send-email-timur@freescale.com> you wrote: > > The value of I2C_TIMEOUT in fsl_i2c.c has several problems. First, it is > > defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes > > no sense to derive it from a clock rate. Second, the current value (250) is > > too low for some boards, so it needs to be increased. Third, the timeout > > necessary for multiple-master arbitration is larger than the timeout for basic > > read/write operations, so we shouldn't have a single constant for both timeouts. > > Finally, it would be nice if we could override these values on a per-board > > basis. > > > > Signed-off-by: Timur Tabi > > --- > > drivers/i2c/fsl_i2c.c | 24 ++++++++++++++++++++---- > > 1 files changed, 20 insertions(+), 4 deletions(-) > > Acked-by: Wolfgang Denk Tested-by: Peter Tyser Acked-by: Peter Tyser Looks good to me, Peter